Major overhaul of the type system to manage typed proof search with an easier-to-maintain and less invasive API#53
Open
jrosain wants to merge 11 commits intoGoelandProver:masterfrom
Open
Conversation
2780a16 to
cc89202
Compare
cc89202 to
f0c5429
Compare
f0c5429 to
c064455
Compare
ab5b778 to
917dfa1
Compare
917dfa1 to
02d53ef
Compare
02d53ef to
0ead997
Compare
* non destructive search **does not** manage typed search, only destructive search does * dmt might be incompatible with typed search
0ead997 to
0c627a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Closes: #38
Description
I've totally removed the old typing system and reworked it in something new:
MixedSubstitution, which stores both term and type substitutions. Adapted the destructive proof search to make use of it. DMT is not fully supported yet, but I think the update is straightforward. Non-destructive search does not support mixed substitutions (as an aside, maybe we should cleanup the non destructive version, it doesn't work anyway so we could simply return errors saying this isn't implemented yet or simply remove the option to do non-destructive search).PR dependencies
*FormListbyLib.List[Form]#46Test-suite update
test-suite/proofs/tf1_basic_thm.ptest-suite/proofs/tf1_basic_thm-2.ptest-suite/bugs/bug_53-1.ptest-suite/basic/test-typing-elab-n.pto check the ad-hoc polymorphism of defined arithmetic functions and the edge case of quotients